Simplify generated code #2131
Merged
Simplify generated code #2131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: A number of things have changed since the generated code was initially designed, which means it can be simplified and improved. Modifications: - As services are namespaced within a namespace-service enum (rather than within a service enum in a namespace enum), they no longer need to be grouped by namespace. - As deployment targets must be set in the package manifest, the generated code no longer needs to be annotated with availability guards so these have been removed. Result: Simpler code generation, better generated code.
rnro
reviewed
Nov 26, 2024
| if let comment = description.comment { renderComment(comment) } | ||
| let item = description.item | ||
| renderCodeBlockItem(item) | ||
| if let item = description.item { |
There was a problem hiding this comment.
The previous style had a cleaner call site; what was the impetus to change?
There was a problem hiding this comment.
description.item is now Optional, so we need this change (or for renderCodeBlockItem to take an optional)
rnro
approved these changes
Nov 26, 2024
glbrntt
pushed a commit
that referenced
this pull request
Dec 4, 2024
## Motivation #2131 removed all usages of availability guards. However, the `guarded` Declaration case was not removed even though it's unused. ## Modifications This PR removes the `guarded` case since it's not used anywhere anymore. ## Result Cleaner codebase.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
A number of things have changed since the generated code was initially designed, which means it can be simplified and improved.
Modifications:
Result:
Simpler code generation, better generated code.